Skip to content

OCPBUGS-65634: add service account to curl job#594

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
ehearne-redhat:add-service-account-curl-job
Jan 20, 2026
Merged

OCPBUGS-65634: add service account to curl job#594
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
ehearne-redhat:add-service-account-curl-job

Conversation

@ehearne-redhat
Copy link
Contributor

@ehearne-redhat ehearne-redhat commented Jan 7, 2026 •
edited
Loading

This PR adds a service account to the curl job, so that it doesn't use a default service account. The reason for this is that default service account usage should be avoided, and a bespoke service account should be used where possible.

The service account is also cleaned up after the curl job finishes/deletes itself.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 7, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2026

@ehearne-redhat: This pull request references Jira Issue OCPBUGS-65634, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ehearne-redhat ehearne-redhat force-pushed the add-service-account-curl-job branch from 59e1fb0 to 5097073 Compare January 7, 2026 14:37
@ehearne-redhat
Copy link
Contributor Author

ehearne-redhat commented Jan 8, 2026

/retest

@ehearne-redhat ehearne-redhat force-pushed the add-service-account-curl-job branch from 816d2fc to e596858 Compare January 9, 2026 12:53
@ehearne-redhat ehearne-redhat force-pushed the add-service-account-curl-job branch from 788ac6e to 47e7072 Compare January 12, 2026 13:21
@ehearne-redhat
Copy link
Contributor Author

ehearne-redhat commented Jan 13, 2026

/test openshift-e2e-aws

@ehearne-redhat
Copy link
Contributor Author

ehearne-redhat commented Jan 13, 2026

/retest

@ehearne-redhat
Copy link
Contributor Author

ehearne-redhat commented Jan 13, 2026

I'm unsure why this test openshift-e2e-aws continues to fail. However, the failing file test/e2e/single_namespace_support_test.go seems to be removed in a future PR #597 .

This test isn't marked as required, so I will move this PR out of WIP.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@ehearne-redhat: This pull request references Jira Issue OCPBUGS-65634, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

Details

In response to this:

This PR adds a service account to the curl job, so that it doesn't use a default service account. The reason for this is that default service account usage should be avoided, and a bespoke service account should be used where possible.

The service account is also cleaned up after the curl job finishes/deletes itself.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ehearne-redhat ehearne-redhat changed the title [WIP] OCPBUGS-65634: add service account to curl job OCPBUGS-65634: add service account to curl job Jan 13, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/test openshift-e2e-aws

@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/hold
Need to wait until #597 (sync) merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026
@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/unhold

PR597 merged, you might need to rebase.

@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/test openshift-e2e-aws

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026
@ehearne-redhat
Copy link
Contributor Author

ehearne-redhat commented Jan 14, 2026

@tmshort all tests passed - could you review?

@openshift-bot openshift-bot mentioned this pull request Jan 21, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 22, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
d7f1ffc 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 23, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
8e65893 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
@openshift-bot openshift-bot mentioned this pull request Jan 23, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 24, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
5b3a9b5 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 27, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
0ab146f 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 27, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
786abeb 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 28, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
5c02053 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 29, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
a57d2fc 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 29, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
3d6e1b8 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 30, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
807634b 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Jan 31, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
2d00bab 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
@openshift-bot openshift-bot mentioned this pull request Jan 31, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 1, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
236b261 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 2, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
7023007 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
perdasilva pushed a commit to perdasilva/operator-framework-operator-controller that referenced this pull request Feb 2, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
a8c8c89 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 2, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
7518e6b 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 2, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
f34cb6c 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
@openshift-bot openshift-bot mentioned this pull request Feb 2, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 3, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
a88c787 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 3, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
789f36f 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 3, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
2916333 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 4, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
db2f92c 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 4, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
64025d9 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
@openshift-bot openshift-bot mentioned this pull request Feb 4, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 4, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
585ae34 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 6, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
efbc830 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
@openshift-bot openshift-bot mentioned this pull request Feb 6, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-operator-controller that referenced this pull request Feb 7, 2026
@sosiouxme
UPSTREAM: <carry>: Revert "Merge pull request openshift#594 from ehea…
1deeca8 
…rne-redhat/add-service-account-curl-job"

This reverts commit eccd759, reversing
changes made to dcbfaf2.
@openshift-bot openshift-bot mentioned this pull request Feb 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

@anik120 anik120 Awaiting requested review from anik120

@dtfranz dtfranz Awaiting requested review from dtfranz

1 more reviewer

@grokspawn grokspawn grokspawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grokspawn grokspawn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ehearne-redhat @openshift-ci-robot @tmshort @kuiwang02 @grokspawn